Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove t_start #764

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Remove t_start #764

merged 2 commits into from
Sep 12, 2024

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Sep 11, 2024

t_start and reference_date were probably used with the following way: reference_date might have been the first date available in a file, and t_start allowed to run at at different point in that file. These capabilities are no longer needed, as everything can be done directly with start_date.

t_start and reference_date will be deprecated in ClimaUtilities and ClimaDiagnostics

CliMA/ClimaUtilities.jl#109
CliMA/ClimaDiagnostics.jl#75

Closes #761

@Sbozzolo Sbozzolo force-pushed the gb/tstart branch 2 times, most recently from f84c887 to 25a03bf Compare September 11, 2024 03:16
@Sbozzolo Sbozzolo force-pushed the gb/tstart branch 3 times, most recently from 9c83b81 to 6bca66b Compare September 11, 2024 04:13
@Sbozzolo Sbozzolo marked this pull request as ready for review September 11, 2024 15:17
@Sbozzolo Sbozzolo requested a review from kmdeck September 11, 2024 15:17
Copy link
Member

@kmdeck kmdeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@Sbozzolo Sbozzolo merged commit 69d623c into main Sep 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove t_start
2 participants