Change albedo artifacts to use ClimaArtifacts #820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both cesm2_albedo_dataset_path and bareground_albedo_dataset_path now use the new ClimaArtifact cesm2_albedo. This commit also deletes src/standalone/Bucket/artifacts, which was in an include, but never used.
Previously, the there were to functions in Artifacts.jl, bareground_albedo_dataset_path and cesm2_albedo_dataset_path. These now call a single function cesm2_albedo_dataset_folder and join path with the correct file name. To completely conform to the way other ClimaArtifacts are used, the two functions that return the specific file path should be removed. However, this would make the places the files are used messy, so I left the functions.
Note that esw_albedo_Amon_CESM2_historical_r1i1p1f1_gn_185001-201412_v2.nc is replaced with sw_albedo_Amon_CESM2_historical_r1i1p1f1_gn_185001-201412_v2_no-nans.nc, which is exactly the same.
For more details see related ClimaArtifacts PR here
Purpose
This PR progressed towards #580
It gets rid of ArtifactWrappers for land albedo and average bareground albedo.
To-do
Content