-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Formatting with Format #947
Conversation
4ba901a
to
7477f97
Compare
7477f97
to
f71e665
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Teja! I wonder if we even need to keep the Format.jl dependency. It looks like it's only used in one place for met_drivers_FLUXNET.jl and the corresponding lib/ClimaLandSimulations file make_drivers.jl.
Dates.jl also has a function Dates.format
that might do what we need. Or if we're only keeping Format around for one function, we could potentially implement it ourselves. Maybe @AlexisRenchon or @Espeer5 will know if we added Format.jl just for the two calls linked above?
Hmm it's been a while since I wrote this. I think the problem was that the data would automatically be read in as a number and formatted as "##e##" or something like this... I will make a separate issue to work on this as I also want to generalize these scripts to read a specified start date so that the ClimaArtifact for the fluxtower data can be updated to include the full data sets. In the process I will see if I can remove the dependency on Format. |
That sounds like a good plan! In the meantime, we can go ahead with this PR to at least remove the docs warning about Formatting.jl |
I briefly looked into it when replacing Formatting with Format. It seems like format is used because to parse something in the For example:
could be
This should be fine because the original would still error if a non-whole number is given. |
Purpose
Formatter.jl is no longer maintained. This PR replaces its usage with Format.jl
Closes #937
To-do
Content