Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Plots from buildkite #957

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Remove Plots from buildkite #957

merged 1 commit into from
Dec 18, 2024

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Dec 16, 2024 •
edited
Loading

Purpose

  • Switches to CairoMakie for the rest of our experiments, and removes Plots from Project toml and manifest
  • alters some parameters of the US-MOz site
  • removes an allocation from a previous PR in soil_canopy_root_interactions
  • removes bug in previous fluxnet plotting which would make column as absent if < 0.5% was missing. Now we increase the threshold to 10%.
  • I have read and checked the items on the review checklist.

@kmdeck kmdeck force-pushed the kd/fluxtower_plots branch 2 times, most recently from 41fe260 to 541a15e Compare December 17, 2024 16:48
kmdeck
kmdeck commented Dec 17, 2024
View reviewed changes
experiments/integrated/fluxnet/run_fluxnet.jl
@@ -30,11 +29,11 @@ include(joinpath(climaland_dir, "experiments/integrated/fluxnet/data_tools.jl"))
include(joinpath(climaland_dir, "experiments/integrated/fluxnet/plot_utils.jl"))

# Read in the site to be run from the command line
#if length(ARGS) < 1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was leftover from a previous PR on accident

@kmdeck kmdeck changed the title Kd/fluxtower plots Remove Plots from buildkite Dec 17, 2024
@kmdeck kmdeck marked this pull request as ready for review December 18, 2024 17:06
AlexisRenchon
AlexisRenchon approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@AlexisRenchon AlexisRenchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thank you Kat!

Espeer5
Espeer5 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@Espeer5 Espeer5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kmdeck kmdeck force-pushed the kd/fluxtower_plots branch from b62e798 to b698f87 Compare December 18, 2024 20:29
@kmdeck kmdeck enabled auto-merge (squash) December 18, 2024 20:30
@kmdeck kmdeck merged commit 75991d8 into main Dec 18, 2024
16 checks passed
@kmdeck kmdeck deleted the kd/fluxtower_plots branch December 18, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Espeer5 Espeer5 Espeer5 approved these changes

@AlexisRenchon AlexisRenchon AlexisRenchon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmdeck @AlexisRenchon @Espeer5