-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distributions parameters 2-moment scheme #191
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 2 2
Lines 134 134
=======================================
Hits 132 132
Misses 2 2 ☔ View full report in Codecov by Sentry. |
I saw that in ClimaParams I cannot define parameters with a negative value. Since \mu for the rain distribution is negative, I defined it here as positive, and then I'll change the signs in the documentation and in the 2-moment computations. Is that okay? |
Why do you think you can't have negative numbers? I think we do have some negative parameters... I can try again, maybe it was because there was a space between the - and the number |
Ok perfect, you're right! Now it's negative! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
You will also need to change the version in the Project.toml
Line 4 in d19d043
version = "0.10.5" |
to 0.10.6
so that we can make a patch release.
Purpose
To-do
Content