WIP: Starting river-model infrastructure #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odunbar
changed the title
achiang17
force-pushed
the
orad/river-model-infrastructure
branch
from
fff0946 to
b8b86b2
Compare
kmdeck
reviewed
Nov 27, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
|
|
||
| # Remove duplicates to ensure each basin appears only once | ||
| return unique(upstream_basin_list) | ||
| end |
There was a problem hiding this comment.
It would be great to add a unit test for this function!
There was a problem hiding this comment.
we could use the mini-IRF basin network as a basis for unit testing.
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
kmdeck
reviewed
Dec 3, 2024
odunbar
commented
Dec 4, 2024
|
|
||
| # Remove duplicates to ensure each basin appears only once | ||
| return unique(upstream_basin_list) | ||
| end |
There was a problem hiding this comment.
we could use the mini-IRF basin network as a basis for unit testing.
achiang17
force-pushed
the
orad/river-model-infrastructure
branch
2 times, most recently
from
54f909e to
43966e5
Compare
Refactoring Mizuroute v1
achiang17
force-pushed
the
orad/river-model-infrastructure
branch
from
43966e5 to
ee563ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #9
Closes #10
Closes #11
Details found in #6
To-do
Content