Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instantaneous zenith angle computation #51

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Update instantaneous zenith angle computation #51

merged 2 commits into from
Nov 1, 2023

Conversation

sriharshakandala
Copy link
Member

@sriharshakandala sriharshakandala commented Oct 31, 2023 •
edited
Loading

Purpose

Update instantaneous zenith angle computation

Issue: CliMA/ClimaAtmos.jl#2314

  • I have read and checked the items on the review checklist.

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bda8307) 98.88% compared to head (4568c03) 98.98%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   98.88%   98.98%   +0.10%     
==========================================
  Files           4        4              
  Lines          90       99       +9     
==========================================
+ Hits           89       98       +9     
  Misses          1        1
Files Coverage Δ
src/ZenithAngleCalc.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sriharshakandala sriharshakandala force-pushed the sk/update_inst_zen_ang_comp branch from 3133939 to 64fbdf7 Compare November 1, 2023 00:24
@sriharshakandala sriharshakandala force-pushed the sk/update_inst_zen_ang_comp branch from cbd8bc6 to 482cecf Compare November 1, 2023 17:05
@sriharshakandala sriharshakandala marked this pull request as ready for review November 1, 2023 17:55
@sriharshakandala
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Nov 1, 2023
@bors @sriharshakandala
Merge #51
e437ab0 
51: Update instantaneous zenith angle computation r=sriharshakandala a=sriharshakandala



Co-authored-by: sriharshakandala <sriharsha.kvs@gmail.com>
@bors bors
Copy link
Contributor

bors bot commented Nov 1, 2023

Build failed:

@sriharshakandala
Copy link
Member Author

bors r+

@bors bors
Copy link
Contributor

bors bot commented Nov 1, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 3020aba into main Nov 1, 2023
9 checks passed
@bors bors bot deleted the sk/update_inst_zen_ang_comp branch November 1, 2023 20:44
@simonbyrne simonbyrne mentioned this pull request Nov 1, 2023
Merged
1 task
@sriharshakandala sriharshakandala linked an issue Nov 2, 2023 that may be closed by this pull request
Update instantaneous zenith angle computation #57
Closed
@sriharshakandala sriharshakandala mentioned this pull request Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

@simonbyrne simonbyrne Awaiting requested review from simonbyrne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update instantaneous zenith angle computation
2 participants
@sriharshakandala @szy21