-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve OrbitalData inference #77
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 98.93% 98.94% +0.01%
==========================================
Files 4 4
Lines 94 95 +1
==========================================
+ Hits 93 94 +1
Misses 1 1 ☔ View full report in Codecov by Sentry. |
4b284c7
to
9fb63bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change slightly modifies the function:
- now
x[1, 1]
andx[end, 1]
have to be integer - the independent variable in the spline is now defined in terms of integers instead of floats
But I don't see any problems with these, so I'd say that we can go ahead with the change.
Maybe we can add one line of comment to mention that this code looks a little funky to ensure type stability. (And format before merging)
Improve OrbitalData inference
9fb63bb
to
c24627e
Compare
I was able to remove the Int conversion while still fixing inference failures, it was just the |
This PR adds some type assertions to fix some JET failures (from 145 -> 73). The remaining ones are in DelimitedFiles and Interpolations.