Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OrbitalData inference #77

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Improve OrbitalData inference #77

merged 4 commits into from
Sep 12, 2024

Conversation

charleskawczynski
Copy link
Member

This PR adds some type assertions to fix some JET failures (from 145 -> 73). The remaining ones are in DelimitedFiles and Interpolations.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (cc49082) to head (43349c3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   98.93%   98.94%   +0.01%     
==========================================
  Files           4        4              
  Lines          94       95       +1     
==========================================
+ Hits           93       94       +1     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Insolation.jl Outdated Show resolved Hide resolved
Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change slightly modifies the function:

  • now x[1, 1] and x[end, 1] have to be integer
  • the independent variable in the spline is now defined in terms of integers instead of floats

But I don't see any problems with these, so I'd say that we can go ahead with the change.

Maybe we can add one line of comment to mention that this code looks a little funky to ensure type stability. (And format before merging)

@charleskawczynski
Copy link
Member Author

I was able to remove the Int conversion while still fixing inference failures, it was just the readdlm that was type-unstable.

@charleskawczynski charleskawczynski merged commit 42f9387 into main Sep 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants