Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ClimaParams compat #514

Closed
wants to merge 1 commit into from
Closed

Update ClimaParams compat #514

wants to merge 1 commit into from

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Jul 2, 2024 •
edited
Loading

RRTMGP depends on new parameters added in ClimaParams v0.10.8, this ensures that older versions will not be grabbed.

I have also updated the docs manifest.

@nefrathenrici nefrathenrici requested a review from szy21 July 2, 2024 21:33
@szy21
Copy link
Member

szy21 commented Jul 2, 2024

Was ClimaParams just removed here: #513?

@nefrathenrici
Copy link
Member Author

Was ClimaParams just removed here: #513?

ClimaParams was removed as a direct dependency, is still a weakdep for the extension.

@szy21
Copy link
Member

szy21 commented Jul 2, 2024

Was ClimaParams just removed here: #513?

ClimaParams was removed as a direct dependency, is still a weakdep for the extension.

I see. What parameters in v0.10.8 are used? (CliMA/ClimaParams.jl#198 is used in ClimaAtmos, not RRTMGP). We can still update the compat though.

@nefrathenrici
Copy link
Member Author

Was ClimaParams just removed here: #513?

ClimaParams was removed as a direct dependency, is still a weakdep for the extension.

I see. What parameters in v0.10.8 are used? (CliMA/ClimaParams.jl#198 is used in ClimaAtmos, not RRTMGP). We can still update the compat though.

If the parameters are only used in Atmos, we should keep the compat lower here. I will make sure the update the atmos compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nefrathenrici @szy21