Improve readability of some assigments #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `flux_dn_dir` was not set in the two stream case for non-gray radiation, leading to garbage values (whatever was in the memory at init). Now, the variable is accumulated over for ever g-point.
A pattern like ``` map!(x -> x, view(flux_up_sw, :, gcol), view(flux_up, :, gcol)) ``` is quite hard to understand for what it does. It takes a couple of minutes to understand that it is just an assignment and it equivalent to ``` flux_up_sw[:, gcol] = flux_up[:, gcol] ``` I removed these instances and replaced them with a clear assignment. On CPU, this is 1 % slower, but I think that well worth for the added readability. ``` julia> @benchmark map!(x -> x, view(A, :, 1), view(B, :, 1)) BenchmarkTools.Trial: 10000 samples with 6 evaluations. Range (min … max): 4.966 μs … 12.451 μs ┊ GC (min … max): 0.00% … 0.00% Time (median): 5.037 μs ┊ GC (median): 0.00% Time (mean ± σ): 5.063 μs ± 141.562 ns ┊ GC (mean ± σ): 0.00% ± 0.00% ▂▇█▅▁ ▁▂▅█████▆▄▃▂▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁ ▂ 4.97 μs Histogram: frequency by time 5.69 μs < Memory estimate: 128 bytes, allocs estimate: 4. julia> @benchmark view(A, :, 1) .= view(B, :, 1) BenchmarkTools.Trial: 10000 samples with 6 evaluations. Range (min … max): 4.913 μs … 13.299 μs ┊ GC (min … max): 0.00% … 0.00% Time (median): 5.086 μs ┊ GC (median): 0.00% Time (mean ± σ): 5.121 μs ± 194.785 ns ┊ GC (mean ± σ): 0.00% ± 0.00% ▄▇██▇▅▃▁ ▂ ▅▃▃▁▄████████████▇▆▄▃▄▅▆▇▇▆▆▆▆▇▆▇▇▆▅▆▆▆▆▇▇▅▆▅▅▆▅▆▆▅▆▇▄▆▆▅▄▆ █ 4.91 μs Histogram: log(frequency) by time 6.04 μs < Memory estimate: 224 bytes, allocs estimate: 6. ```
Sbozzolo
force-pushed
the
gb/readability
branch
from
737917e to
e6f5d8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pattern like
is quite hard to understand for what it does. It takes a couple of minutes to understand that it is just an assignment and it equivalent to
I removed these instances and replaced them with a clear assignment.
On CPU, this is 1 % slower, but I think that well worth for the added readability. (It is also not clear if has any impact in the overall performance)