Rename tests. #556
Merged
Rename tests. #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please describe somewhere (e.g., in the commit message, or in the PR message) the reason behind this change? |
I added the comment in the PR description! |
Sbozzolo
approved these changes
Oct 10, 2024
Thank you, the comment is very useful to explain this change. |
Rename: rfmip_clear_sky => clear_sky all_sky => cloudy_sky all_sky_with_aerosols => all_sky_with_aerosols (no change)
sriharshakandala
force-pushed
the
sk/rename_tests
branch
from
729ad47 to
3d18748
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Rename:
rfmip_clear_sky=>clear_skyall_sky=>cloudy_skyall_sky_with_aerosols=>all_sky_with_aerosols(no change)Reason for change:
The name
all-skycan be a bit confusing. In our most general case, we account for gases, clouds and aerosols for optics computation. However, in the atmospheric modeling community,all-skygenerally means cloudy sky and an additional qualifier (e.g.:all-sky-with-aerosols) is used when aerosol optics contributions are also added. This PR hopes to make these names less ambiguous!