Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add materialization macro for dictionaries #255

Merged

Conversation

SoryRawyer
Copy link
Contributor

Summary

Adds a materialization macro to support materializing models as dictionaries. Tests are included for query-, table-, and HTTP-based dictionaries. These tests also include examples of how to configure models to be materialized as dictionaries.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@jensenity
Copy link

lessgo! been waiting for this!!! 🔥

@bmtcril
Copy link
Contributor

bmtcril commented Mar 14, 2024

Hi @BentsiLeviav and @genzgd we've also been waiting on this one and #254 . Any idea when you might have time to review?

@BentsiLeviav BentsiLeviav self-assigned this Mar 14, 2024
@BentsiLeviav
Copy link
Contributor

Hi folks
I'll do my best to review it within the next few days

Bentsi

@mshustov mshustov requested a review from BentsiLeviav March 17, 2024 13:23
@BentsiLeviav BentsiLeviav merged commit 940ecde into ClickHouse:main Mar 21, 2024
16 checks passed
@SoryRawyer
Copy link
Contributor Author

Thank you, @BentsiLeviav!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants