render fix for tag color and write some unit tests #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlb
changed the title
There was a problem hiding this comment.
Thanks for the PR @dmlb ! See above for my feedback. I think end to end testing would be good for the project, but unit testing might be a bit overkill for the simplicity of the project. Let me know if you disagree though, curious to know what you think.
|
@dmlb I think this is ready to merge now? In terms of workflow for PRs, feel free to re-request reviews so that I know that you're done making changes (or ping me with "good to go" or something). I don't mind being pinged :) |
|
@VeckoTheGecko updated 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adding some unit tests to confirm the colour utilities and component for tag colour are doing what they're supposed to
Fixes #375
needed key on for loop!