Update to 0.104.1 #368
Draft
Update to 0.104.1 #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first commit, so I can try to fix the rest. It compiles and test fail.
The test failed, because some subtotals didn't have correct address. The root cause was the ShiftFormula and ExpandFormula methods. They adjusted only references in a range form ((e.g. `SUBTOTAL(9,I41:I61)`), not single cell form (e.g. `SUBTOTAL(9, I41)`). The condition was added in Initial commit 7 years ago, so it likely isn't needed anymore (regex seems to find references). By removing the redundant condition, test passes.
The test was failing for two reasons: The template contained a <definedName name="Table1Range"> 'Sheet 1'!#REF!</definedName> and when ClosedXML.Report tried to shift the range, a range is shiften, it failed because setter XLDefinedName.ReferesTo tried to extract references from that formula (=no valid references). That was propagated to FormulaReferences.ForFormula where parser reported an empty formula error. That is a ClosedXML error, XLDefinedName.RefersTo setter shouldn't try to get references for empty formula. The second problem was in the Gauges file. It contained formulas that had area form (SUBTOTAL(9,I41:I41)) depsite being single cell (SUBTOTAL(9,I41:I41)). Formulas thus weren't equal and test failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ClosedXML.Report because 0.104.1 was released.
A lot of unit tests is failing, mostly because I modified how defined names are working and I am slowly moving away from automagic that shifts everythign based on ranges.
I will fix tests one by one and familiarize myself with the codebase.