Annotate kubernetes resources #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The annotations handler contains variables and functions that will create or remove annotations on supported Kubernetes objects. Signed-off-by: Elis Lulja <elulja@cisco.com>
Signed-off-by: Elis Lulja <elulja@cisco.com>
Signed-off-by: Elis Lulja <elulja@cisco.com>
The SDWAN uses the annotations channel to notify the annotations handler that an operation -- i.e. inserted or enabled -- was successful. Signed-off-by: Elis Lulja <elulja@cisco.com>
This commit runs the goroutine that watchese for operations updates coming from SDWAN. Signed-off-by: Elis Lulja <elulja@cisco.com>
The provided `ClusterRole` is updated to allow the egress watcher to update supported objects to be annotated by it. Signed-off-by: Elis Lulja <elulja@cisco.com>
This commit includes the `NamespacedName` to SDWAN, so that it can notify the annotations handler that that object can be annotation after a successful operation. Signed-off-by: Elis Lulja <elulja@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the egress watcher to annotate a supported Kubernetes object -- i.e. a
ServiceEntryorNetworkPolicy-- with key that notify whether it was inserted or enabled on the chosen SDWAN.For example, after
kubectl applying aServiceEntrycorrectly, egress watcher will annotate it withegress-watcher.cnwan.io/sdwan-populatedafter it receives a confirmation that it was successfully inserted, and `"egress-watcher.cnwan.io/sdwan-enabled" after a successful configuration/policy update from SDWAN.