Fixes a door-related client-prediction bug #1615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Q: Is this considered as a hack?
SupremeMortal
requested changes
Sep 18, 2020
| @@ -293,6 +293,7 @@ public boolean toggle(Player player) { | |||
| this.getLevel().getServer().getPluginManager().callEvent(event); | |||
|
|
|||
| if (event.isCancelled()) { | |||
| getLevel().sendBlocks(new Player[] {player}, new Block[] {this.down()}); // fixes a client-prediction bug | |||
There was a problem hiding this comment.
If this only affects the upper part of the door, the code should check for that otherwise it's going to update the block below the door when the lower part is pressed.
There was a problem hiding this comment.
@SupremeMortal I know, anyway this fixes it. Updating only the upper half is leading to nothing. Updating both halfs is just unneeded work, as it seems. So just update the lower half.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cancelling the DoorToggleEvent or PlayerInteractEvent, if the player pressed the upper part of the door block it will remain open. Sending an block update to the block below seems to fix this issue.