Fixed Insolator handling of custom recipes (+added config option) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you substantiate this claim? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Phytogenic Insolator with Monoculture Cycle upgrade does not preserve "non-fertilizer" inputs in recipes without fertilizer. Normally this is not an observable problem as there are no recipes without fertilizer. However, it can arise for custom recipes. For example, FTB Interactions significantly changes the recipe to the Monoculture Cycle, clearly with the intention of allowing it to make custom recipes much cheaper, but it does not affect these recipes. This pull request makes it so the Monoculture Cycle upgrade preserves the second input in the case that neither is a fertilizer, and adds a config option to disable this behavior.
I tested that the insulator has its normal behavior under these changes. I did not actually test the handling of custom recipes is now correct though so I'm only 95% sure.
Only the changes to
TileInsolator.javashould be added, I had issues with duplicate jei / no cofh world so I had to change the gradle config a bit.