Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug when there's an error when starting or destroying the bar #538

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Aug 14, 2022

  1. Don't re-assign NoTargetError

    This is in keeping with what looks like the original intention of the Coffeescript source file - that only NoTargetErrors are caught, and other errors are thrown.
    6twenty authored Aug 14, 2022
    Configuration menu
    Copy the full SHA
    099cd75 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Don't check if the error is a NoTargetError

    The way that coffeescript compiles the code means that NoTargetError does not actually act as its own class at all, so `error instanceof NoTargetError` always returns `false`.
    
    Since the original error handling code did not raise any exceptions at all (regardless if it was a NoTargetError or not), I've done the same here so that the functionality is identical (save for not reassigning NoTargetError).
    6twenty authored Aug 15, 2022
    Configuration menu
    Copy the full SHA
    7b03824 View commit details
    Browse the repository at this point in the history