Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizing Python + Docker deploys using Pants #44

Merged
merged 22 commits into from
Oct 17, 2022
Merged

Optimizing Python + Docker deploys using Pants #44

merged 22 commits into from
Oct 17, 2022

Conversation

esirK
Copy link
Contributor

@esirK esirK commented Oct 5, 2022 •
edited by kilemensi
Loading

Description

This PR uses Optimizing Python + Docker deploys using Pants article to optimize our use of pants to build Docker images.

The PR also standardize use of environment variables by prefixing each one with TWOOPSTRACKER_, remove the mixing of twoops-tracker, twoops_tracker, etc. to just twoopstracker for package name.

Fixes #6

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (non-breaking change which does not add visible functionality but improves code quality)
  • This change requires a documentation update

Screenshots

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@esirK esirK self-assigned this Oct 5, 2022
@esirK esirK added the chore A task that needs to be done (neither enhancement or bug) label Oct 5, 2022
kilemensi
kilemensi reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

If we’re moving away from pex, should we move away from the whole dj app?

thepsalmist
thepsalmist reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@thepsalmist thepsalmist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @esirK

@kilemensi kilemensi changed the title Chore ditch running pex in the container and just extract it's content and run them natively in container Optimizing Python + Docker deploys using Pants Oct 10, 2022
@kilemensi kilemensi added the documentation Improvements or additions to documentation label Oct 10, 2022
@kilemensi kilemensi self-requested a review October 10, 2022 14:04
thepsalmist
thepsalmist reviewed Oct 11, 2022
View reviewed changes
Copy link
Contributor

@thepsalmist thepsalmist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@esirK
Copy link
Contributor Author

esirK commented Oct 17, 2022

I think this is good to go now @kilemensi @thepsalmist

kilemensi
kilemensi approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@esirK esirK merged commit dbfcc94 into main Oct 17, 2022
@esirK esirK deleted the chore-optimize-image-build branch October 17, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilemensi kilemensi kilemensi approved these changes

@thepsalmist thepsalmist Awaiting requested review from thepsalmist

Assignees

@esirK esirK

Labels
chore A task that needs to be done (neither enhancement or bug) documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize Python + Docker deployment
3 participants
@esirK @kilemensi @thepsalmist