Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/user action permissions #34

Merged
merged 10 commits into from
Jun 11, 2024
Merged

Conversation

thepsalmist
Copy link
Contributor

Description

This PR introduces modifications to some of CKAN's default auth settings, such as creating/deleting groups,organizations and datasets.

  1. Only sysadmins should create groups & organizations
  2. Only users belonging to na organization should create datasets
  3. Add reCAPTCHA

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Screenshot 2024-05-28 at 09 22 33

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we deleting Dockerfile?

contrib/ckan/docker-entrypoint.d/openafrica_ckan.sh Outdated Show resolved Hide resolved
@kilemensi
Copy link
Member

Why are we deleting Dockerfile?

@thepsalmist ☝🏽 ... why are we deleting Dockerfile and keeping Dockerfile.dev?

@thepsalmist
Copy link
Contributor Author

Why are we deleting Dockerfile?

@thepsalmist ☝🏽 ... why are we deleting Dockerfile and keeping Dockerfile.dev?

We have respective Dockerfiles in contrib/. This was cleanup. I think we need Dockefle.dev

@kilemensi
Copy link
Member

kilemensi commented May 28, 2024

We have respective Dockerfiles in contrib/. This was cleanup. I think we need Dockefle.dev

It's a bit confusing @thepsalmist ... I'm looking at the docker-compose-dev.yml file and it's pointing to

      build:
        context: contrib/postgres
        dockerfile: Dockerfile

Not sure what is what. Why do we need a separate dev? Why not switch to multi-stage if we do indeed need a different dev?

@thepsalmist thepsalmist requested review from kilemensi and removed request for kilemensi June 7, 2024 11:55
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

--

Just for my understanding, what is the issue that defining PYTHONPATH solves?

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@thepsalmist
Copy link
Contributor Author

thepsalmist commented Jun 11, 2024

Moved docker multi-stage build changes to new PR tracked here #35

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
thepsalmist and others added 2 commits June 11, 2024 16:59
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
@thepsalmist thepsalmist merged commit f46b319 into master Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants