Ft/upgrade next to 15 #1001
Open
Ft/upgrade next to 15 #1001
+1,694
−1,925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nresolved imports for SVG files
…nder-result-naming-convention rule
kilemensi
reviewed
Nov 28, 2024
| const flatCompat = new FlatCompat(); | ||
|
|
||
| module.exports = [ | ||
| ...fixupConfigRules(flatCompat.extends("plugin:@next/next/core-web-vitals")), |
There was a problem hiding this comment.
@kilemensi I came across this issue and the only workaround I had was to use eslint compatibility utilities to fix up things.
kilemensi
reviewed
Dec 2, 2024
| @@ -59,7 +59,7 @@ const Articles = React.forwardRef(function Articles(props, ref) { | |||
| undefined, | |||
| { scroll: false, shallow: true }, | |||
| ); | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
| /* eslint react-hooks/exhaustive-deps: "off" */ | |||
There was a problem hiding this comment.
- Why are we changing these? They seem to still be supported.
- Doesn't "off" disable them for the rest of the file instead of just the next line as the original intended?
| @@ -7,7 +7,7 @@ | |||
| "build": "next build", | |||
| "start": "next start", | |||
| "lint-check": "TIMING=1 next lint './'", | |||
| "lint": "TIMING=1 next lint --fix './'", | |||
| "lint": "TIMING=1 eslint --fix './'", | |||
There was a problem hiding this comment.
Does this go through the Next.js linting?
Comment on lines
11
to
+16
| apiUrl: string; | ||
|
|
||
| fingerprint?: string; | ||
|
|
||
| timeout?: number; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the Next.js framework from the current version to v15.0.3 to leverage on the latest features, performance improvements, and bug fixes introduced in this release.
Key Changes
.eslintignoreand.eslintrcsince with flatConfigs all can be defined in eslint.config.js.You may notice many changed files in component files, but this is due to a change in how to disable a rule in a file with flat configs.
// eslint-disable-next-line testing-library/render-result-naming-conventioninside the test file since this disable command has been specified in common eslint config"testing-library/render-result-naming-convention": "off",.// eslint-disable-next-line react-hooks/exhaustive-depsoccurrences have now been replaced with/* eslint react-hooks/exhaustive-deps: "off" */Review of this PR should be around
*/**/eslint.config.jsandpackages/eslint-config-commons-uiFixes # (issue)
Type of change
Please delete options that are not relevant.
Screenshots
Checklist: