-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useStyles from HURUMap #1008
Open
kelvinkipruto
wants to merge
24
commits into
main
Choose a base branch
from
ft/climatemapped-remove-usestyles-hurumap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinkipruto
requested review from
kilemensi and
m453h
and removed request for
kilemensi
November 29, 2024 10:06
kilemensi
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kilemensi
added
the
chore
A task that needs to be done (neither enhancement or bug)
label
Nov 29, 2024
Headings look good now @kelvinkipruto but Select looks off. |
m453h
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me 🚀 I only have a few very minor issues
- There’s an issue with the Pin and Compare component when focused, I can see the shadow/tint slightly overlaps the border radius. Although this is visible in the deployed app, it’s more noticeable in the current version 👇
"& .MuiSelect-filled:focus": {
borderRadius: theme.typography.pxToRem(6),
},
- Some of these icons look like they are cut at the bottom, Not sure why this is happening though might be a good idea to fix them on the same PR, and I was just thinking out loud since we are using 𝕏 instead of the bird as one of the social media icons on the footer, don't we need to update this one as well 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
useStyles
from HURUMapType of change
Screenshots
Checklist: