Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useStyles from HURUMap #1008

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Nov 27, 2024

Description

This PR removes useStyles from HURUMap

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

image
image
image
image
iPhone 12 Pro-1732875510535
iPhone 12 Pro-1732875577791

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kelvinkipruto kelvinkipruto marked this pull request as ready for review November 27, 2024 13:52
@kelvinkipruto kelvinkipruto requested review from kilemensi and m453h and removed request for kilemensi November 29, 2024 10:06
@kilemensi kilemensi requested a review from a team November 29, 2024 10:53
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽


Haven't checked the code but you've changed heading spacing and things look unbalanced.
S

@kilemensi kilemensi added the chore A task that needs to be done (neither enhancement or bug) label Nov 29, 2024
@kilemensi
Copy link
Member

Headings look good now @kelvinkipruto but Select looks off.
S

Copy link
Contributor

@m453h m453h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me 🚀 I only have a few very minor issues

  1. There’s an issue with the Pin and Compare component when focused, I can see the shadow/tint slightly overlaps the border radius. Although this is visible in the deployed app, it’s more noticeable in the current version 👇
Screenshot 2024-11-29 at 20 21 41 I played a bit with the CSS on the browser but explicitly setting the borderRadius on focus state kinda solves the problem:
 "& .MuiSelect-filled:focus": {
            borderRadius: theme.typography.pxToRem(6),
 },
Screenshot 2024-11-29 at 20 37 41
  1. Some of these icons look like they are cut at the bottom, Not sure why this is happening though might be a good idea to fix them on the same PR, and I was just thinking out loud since we are using 𝕏 instead of the bird as one of the social media icons on the footer, don't we need to update this one as well 🤔
Screenshot 2024-11-29 at 21 08 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that needs to be done (neither enhancement or bug)
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants