Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@/codeforafrica Implement Settings #516

Merged
merged 67 commits into from
Sep 9, 2023
Merged

@/codeforafrica Implement Settings #516

merged 67 commits into from
Sep 9, 2023

Conversation

koechkevin
Copy link
Contributor

@koechkevin koechkevin commented Jul 21, 2023 •
edited by kilemensi
Loading

Description

Implement Settings global in the CMS an use it to power the existing front-end site level data. These include:

  • General
    • Title and Description [Footer]
    • Logos (primary and secondary) [NavBar and Footer]
  • Navigation (primary and secondary) [NavBar and Footer],
  • Engagement,
    • Social Accounts (NavBar and Footer)
    • Newsletter Subscription (Footer)

Fixes #508

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

S

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@vercel
Copy link

vercel bot commented Jul 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeforafrica ❌ Failed (Inspect) Jul 31, 2023 3:28pm

@koechkevin koechkevin self-assigned this Jul 21, 2023
@koechkevin koechkevin requested a review from kilemensi September 6, 2023 09:24
kilemensi
kilemensi reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

apps/codeforafrica/src/components/FooterLinks/FooterLinks.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/globals/Footer.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/globals/Footer.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/globals/Footer.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/globals/Footer.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/lib/data/common/globals.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/lib/data/common/globals.js Outdated Show resolved Hide resolved
@koechkevin koechkevin requested a review from kilemensi September 7, 2023 06:11
@kilemensi kilemensi mentioned this pull request Sep 7, 2023
Merged
4 tasks
@koechkevin
Copy link
Contributor Author

@kelvinkipruto test this out once more

@kelvinkipruto
Copy link
Contributor

@koechkevin All looks well except the description. The links should be underlined by default, not just on hover.

kilemensi
kilemensi approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kilemensi kilemensi changed the title Update footer @/codeforafrica Implement Settings Sep 9, 2023
@koechkevin koechkevin merged commit 2a60ab4 into develop Sep 9, 2023
@koechkevin koechkevin deleted the feature/global-footer branch September 9, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvinkipruto kelvinkipruto kelvinkipruto approved these changes

@kilemensi kilemensi kilemensi approved these changes

@saminegash saminegash Awaiting requested review from saminegash

Assignees

@koechkevin koechkevin

Labels
enhancement New feature or request
Projects
COMMONS
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koechkevin @kelvinkipruto @kilemensi