@/climatemappedafrica - chore: remove defaultProps in functional components #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponents with removed default props
koechkevin
reviewed
Aug 29, 2024
Yes, I agree. Initially, I thought moving everything from defaultProps to the function parameters would add value, but I later realized it was unnecessary verbosity. Looks like I forgot to change this one ! Co-authored-by: KEVIN KOECH <koechkevin92@gmail.com>
kilemensi
reviewed
Aug 29, 2024
apps/climatemappedafrica/src/components/HURUmap/Panel/DesktopPanel/PanelItem.js
Outdated
Show resolved
Hide resolved
apps/climatemappedafrica/src/components/HURUmap/Tutorial/index.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
…ub.com:CodeForAfrica/ui into chore/climatemappedafrica-remove-default-props
…anel/PanelItem.js Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
…ub.com:CodeForAfrica/ui into chore/climatemappedafrica-remove-default-props
kilemensi
approved these changes
Aug 30, 2024
koechkevin
approved these changes
Aug 30, 2024
kelvinkipruto
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
defaultPropswhich are depecrated in React 18 and will be removed in React 19 in favour of ES6 default parameters in all functional components in theclimatemappedafrica.This is the first step towards implementing these changes across all apps in this repo.
Type of change
Please delete options that are not relevant.
Checklist: