Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List cases awaiting your action #35

Closed
timwis opened this issue Oct 19, 2016 · 4 comments
Closed

List cases awaiting your action #35

timwis opened this issue Oct 19, 2016 · 4 comments
Labels
Milestone

Comments

@timwis
Copy link
Member

timwis commented Oct 19, 2016

An "inbox" showing cases which are assigned to you that you have not acted on yet and are currently in the state that you're assigned to.

Edge cases:

  • Cathy and Anna are both Deputy Finance Directors. Contracts can be approved by either of them during the "Awaiting Finance Approval" state.
  • Indebtedness: 2 of the 3 reviewers can submit their action before the state changes

Note: these cases will be covered by #34, so this is less MVP than that one.

@timwis timwis added this to the MVP milestone Oct 19, 2016
@timwis timwis mentioned this issue Oct 19, 2016
@timwis
Copy link
Member Author

timwis commented Oct 19, 2016

Note that the current /cases/awaiting endpoint does not return any assignment tokens with each case. The property is there but it's always null.

@mjumbewu
Copy link
Member

I'm considering adding an is_valid field to Assignment instances. So, in the case where Cathy and Anna are both Deputy Finance Directors, when one acts on their assignment, the other's assignment would get is_valid set to False -- perhaps explicitly in the handler, perhaps automatically as a consequence of the case transitioning out of the assigned state with no action taken on the assignment. Probably the latter.

Does that seem reasonable? If the case transitions to another state, then all incomplete assignments are simply marked as invalid?

mjumbewu added a commit that referenced this issue Oct 21, 2016
This may come in handy later if we introduce things like an `is_valid`
field that affects whether the assignment should be considered as
awaiting an action. See issue #35 for more information
@timwis
Copy link
Member Author

timwis commented Oct 21, 2016

@mjumbewu maybe I'm misunderstanding, but I'm not sure that's necessary. If the /cases/awaiting/ endpoint queries cases that (a) are assigned to you, (b) you haven't acted on yet, and (c) the case is currently in the state you're assigned to -- it should handle both scenarios described above, no?

@timwis
Copy link
Member Author

timwis commented Oct 23, 2016

Since this feature has been implemented, I'll close this MVP issue and have copied the is_valid discussion into #52 for further conversation.

@timwis timwis closed this as completed Oct 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants