Make sure children_loaded is checked everywhere it is needed
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
- Coverage 94.94% 94.87% -0.08%
==========================================
Files 2 2
Lines 1247 1248 +1
==========================================
Hits 1184 1184
- Misses 63 64 +1
Continue to review full report at Codecov.
|
libre-man
force-pushed
the
master
branch
3 times, most recently
from
d4db8e1
to
29063e5
Compare
olmokramer
reviewed
Nov 22, 2017
| @@ -1258,6 +1258,7 @@ def get_submission(self, path): | |||
| try: | |||
| submission.tld | |||
| except AttributeError: | |||
| assert submission.children_loaded | |||
There was a problem hiding this comment.
Why assert this here? I thought this should be set in load_submission_files which is called after this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure
children_loadedis checked everywhere it is needed.