draft of the database project #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-systems ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SallyMcGrath
requested changes
May 29, 2024
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
illicitonion
reviewed
Jun 2, 2024
There was a problem hiding this comment.
This looks good, thanks!
I'd consider adding a "think about and discuss" section about the hazards of multiple primaries? Maybe after the "bring up the failed ex-primary" but before the "configure the ex-primary as a new replica" we can insert a "What would happen if someone wrote to the ex-primary before we could re-configure it as a replica?" question, and maybe prompt some consideration of service discovery too? Possibly also worth adding something to think about replication delay and what problems it may cause?
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
SallyMcGrath
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Rationale, briefly
@mentions, #links
@illicitonion @SallyMcGrath @nahratzah