add page_sort and fix bugs #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| fn arr2int(buf:&[u8; 4]) -> u32{ | ||
| ((buf[0] as u32) << 24) | ((buf[1] as u32) << 16) | ((buf[2] as u32) << 8) | (buf[3] as u32) |
There was a problem hiding this comment.
better to use u32::from_bytes_be instead of re-implementing
| ((buf[0] as u32) << 24) | ((buf[1] as u32) << 16) | ((buf[2] as u32) << 8) | (buf[3] as u32) | ||
| } | ||
|
|
||
| fn get_page_number(pages: &mut File, offset: u64) -> Result<u64, Error>{ |
There was a problem hiding this comment.
Realistically we already have innodb::page::Page probably use that.
| } | ||
|
|
||
| fn main(){ | ||
| const PAGE_SIZE: usize = 16384; |
There was a problem hiding this comment.
Again, FIL_PAGE_SIZE is already defined in innodb::page::FIL_PAGE_SIZE
| let mut input_file = File::open(args.input).expect("Failed to open input file"); | ||
|
|
||
| let total_bytes = input_file.seek(std::io::SeekFrom::End(0)).expect("Failed to get input file size"); | ||
| let total_pages = total_bytes / PAGE_SIZE as u64; |
There was a problem hiding this comment.
Really you could just read until there is no more pages any more.
| @@ -165,7 +165,7 @@ impl<'a> Row<'a> { | |||
| let node = LobIndexEntry::try_from_bytes(buf)?; | |||
| trace!("Index Node: {:#?}", node); | |||
|
|
|||
| let mut bytes_read = 0usize; | |||
| let bytes_read; | |||
|
This looks like |
| if bytes_read == 0 { | ||
| break; | ||
| } | ||
| destination.seek(std::io::SeekFrom::Start(destination_offset))?; |
There was a problem hiding this comment.
By the way, seeking beyond EOF is not guaranteed behavior, so we probably should handle this better than just "skipping"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.