Fixed build.cmd command line argument handling #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: build.cmd command line argument handling
About
Currently, if you specify an explicit build mode to build.cmd using a command line argument such as
--Release, the value of the variable buildMode gets extra quotation marks around it which breaks the script, i.e. the value becomes"Release"when it should beRelease. The same happens to the variable noFullPolyCar with the command line argument --no-full-poly-car, but this doesn't actually break anything as the exact value of the variable is never inspected. These changes fix the problem.How Has This Been Tested?
The changes have been tested by running
build.cmd --Release,build.cmd --Debug,build.cmd --RelWithDebInfoandbuild.cmd --no-full-poly-carin x64 Native Tools Command Prompt for VS 2022 on Windows 10.Screenshots (if appropriate):