Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning when summary code suggestions are not supported #1078

Closed
wants to merge 1 commit into from
Closed

Add warning when summary code suggestions are not supported #1078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pr_agent/tools/pr_code_suggestions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,14 @@ async def run(self):

if get_settings().config.publish_output:
self.git_provider.remove_initial_comment()
if ((not get_settings().pr_code_suggestions.commitable_code_suggestions) and
self.git_provider.is_supported("gfm_markdown")):

post_as_summary = not get_settings().pr_code_suggestions.commitable_code_suggestions

if post_as_summary and not self.git_provider.is_supported("gfm_markdown"):
get_logger().warning(f"Git provider does not support summary code suggestions. Reverting to commitable_code_suggestions=True.")
post_as_summary = False

if post_as_summary:
# generate summarized suggestions
pr_body = self.generate_summarized_suggestions(data)
get_logger().debug(f"PR output", artifact=pr_body)
Expand Down
Loading