refactor: shorten function lengths

Signed-off-by: Ali Sajid Imami <395482+AliSajid@users.noreply.github.com>

R/investigateSignature.R

@@ -74,12 +74,7 @@ investigateSignature <- function(
     sourceCellLine = "NA",
     sourceTime = "NA",
     sourceConcentration = "NA") {
-    libs <- c("OE", "KD", "CP")
-
-    if (!outputLib %in% libs) {
-        stop("Output library must be one of 'OE', 'KD', 'CP'")
-    }
-
+    stopIfInvalidLibraries(outputLib)
     if (missing(outputLib)) {
         stop("Please specify an output library")
     }

R/investigateTarget.R

@@ -51,23 +51,9 @@ investigateTarget <- function(
     similarityThreshold = 0.321,
     paired = TRUE, inputCellLines = NULL,
     outputCellLines = NULL) {
-    libs <- c("OE", "KD", "CP")
-
-    if (!inputLib %in% libs || !outputLib %in% libs) {
-        stop("Both input and output libraries must be one of 'OE', 'KD', 'CP'")
-    }
-
-
-    if (inputLib == "OE") {
-        inputMetadata <- oeMetadata # nolint: object_usage_linter.
-    } else if (inputLib == "KD") {
-        inputMetadata <- kdMetadata # nolint: object_usage_linter.
-    } else if (inputLib == "CP") {
-        inputMetadata <- cpMetadata # nolint: object_usage_linter.
-    } else {
-        stop("Invalid inputLib")
-    }
+    stopIfInvalidLibraries(c(inputLib, outputLib))
 
+    inputMetadata <- loadMetadata(inputLib)
 
     if (!is.null(inputCellLines)) {
         filteredSignatureIds <- inputMetadata %>%

R/utilities.R

@@ -17,3 +17,49 @@ targetRename <- function(inputNames) {
         )
     }
 }
+
+#' Check if the library is valid
+#'
+#' @param lib a string of libraries
+#'
+#' @return a boolean
+.validateLibrary <- function(lib) {
+    lib %in% c("CP", "KD", "OE")
+}
+
+#' Check if the libraries input are valid
+#'
+#' @param libs a character vector of libraries
+#'
+#' @return a boolean
+validateLibraries <- function(libs) {
+    all(purrr::map_lgl(libs, .validateLibrary))
+}
+
+#' Stop if the libraries are invalid
+#'
+#' @param libs a character vector of libraries
+#'
+#' @return a stop if the libraries are invalid
+stopIfInvalidLibraries <- function(libs) {
+    if (!validateLibraries(libs)) {
+        stop("Both input and output libraries must be one of 'OE', 'KD', 'CP'")
+    }
+}
+
+#' Load the correct metadata table
+#'
+#' @param lib a string. One of "OE", "KD" or "CP"
+#'
+#' @return a tibble
+loadMetadata <- function(lib) {
+    if (lib == "OE") {
+        oeMetadata
+    } else if (lib == "KD") {
+        kdMetadata
+    } else if (lib == "CP") {
+        cpMetadata
+    } else {
+        stop("Invalid library")
+    }
+}