Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Anomap, Rewrite discord-refcount.c #172

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

Anotra
Copy link
Contributor

@Anotra Anotra commented Feb 3, 2024

What?

complete rewrite of discord-refcount.c
anomap_create function has a new flag.
anomap_item_changed has changed.
some new features...

slight change in cache garbage collection to avoid blocking the main thread.

@Anotra Anotra force-pushed the update_anomap branch 3 times, most recently from 68767e2 to 332bc96 Compare February 11, 2024 11:10
@Anotra Anotra force-pushed the update_anomap branch 2 times, most recently from 7342ffe to 8b09803 Compare February 15, 2024 15:25
@Anotra Anotra changed the title fix(anomap): update->latest(breaking function changes), and slight ch… Update Anomap, Rewrite discord-refcount.c Feb 15, 2024
@Anotra
Copy link
Contributor Author

Anotra commented Feb 15, 2024

this should be good. I can fix the concord-once goto bug here as well, or not?...

also, one thing I'm not sure of, does log_conf need a singular lock or not?

@lcsmuller
Copy link
Collaborator

this should be good. I can fix the concord-once goto bug here as well, or not?...

Sure, feel free to add the fix on a separate commit!

also, one thing I'm not sure of, does log_conf need a singular lock or not?

It's likely, considering all log_conf modules are writing to the same file

@Anotra Anotra force-pushed the update_anomap branch 3 times, most recently from aa5ecce to 6714a7b Compare February 19, 2024 21:36
@Anotra
Copy link
Contributor Author

Anotra commented Feb 21, 2024

Feel free to merge whenever, you know it's good.

@Anotra Anotra force-pushed the update_anomap branch 2 times, most recently from b136042 to 0988de4 Compare February 26, 2024 20:40
ThePedroo added a commit that referenced this pull request May 6, 2024
This fix is totally based off Anotra's PR commits #172, adapted to work on dev before the PR is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants