Added a starboard clone as an example #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This project looks like it's dead and no longer maintained. |
|
Works on:
|
|
Great to hear that! |
ThePedroo
reviewed
Aug 6, 2024
| @@ -52,4 +55,4 @@ echo: | |||
| clean: | |||
| @ rm -f $(STD_BOTS) $(VOICE_BOTS) | |||
|
|
|||
| .PHONY: all echo clean | |||
| .PHONY: all echo clean starboard | |||
There was a problem hiding this comment.
I wonder, should we really put it aside?
| discord_set_on_ready(client, &star_bot_on_ready); | ||
| discord_set_on_message_reaction_add(client, &star_main_handler); | ||
| discord_set_on_interaction_create(client, &star_commands_handler); | ||
| discord_run(client); |
There was a problem hiding this comment.
You are not cleaning up the client resources
|
Oh, and you may want to run it against valgrind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
to test it before making changes to Concord.
What?
I added a starboard clone as an example.
Why?
By adding a more complex example, users can learn about the more complicated side of Concord with an example.
How?
Made an example.
Testing?
It works on many machines. I've not yet found any risks, untested conditions or edge cases.
Screenshots
Anything Else?
We could add a guide for installing dependencies on OpenBSD or FreeBSD.