chore: allow delete menu item for concept/approval groups

ColdTrick · Jul 5, 2021 · ccbb9c8 · ccbb9c8
1 parent 2ae4027
commit ccbb9c8
Showing 1 changed file with 20 additions and 4 deletions.
diff --git a/classes/ColdTrick/GroupTools/TitleMenu.php b/classes/ColdTrick/GroupTools/TitleMenu.php
@@ -290,16 +290,24 @@ public static function pendingApproval(\Elgg\Hook $hook) {
 
 		$allowed_items = [
 			'edit',
+			'delete',
 		];
 
 		/* @var $return MenuItems */
 		$return = $hook->getValue();
 
 		// cleanup all items
 		$items = [];
-		/* @var $menu_item \ElggMenuItem */
 		foreach ($allowed_items as $name) {
-			$items[] = $return->get($name);
+			/* @var $item \ElggMenuItem */
+			$item = $return->get($name);
+			$items[] = $item;
+
+			// some items could be in a submenu
+			$parent_name = $item->getParentName();
+			if (!empty($parent_name)) {
+				$items[] = $return->get($parent_name);
+			}
 		}
 
 		$return->fill($items);
@@ -358,16 +366,24 @@ public static function conceptGroup(\Elgg\Hook $hook) {
 
 		$allowed_items = [
 			'edit',
+			'delete',
 		];
 
 		/* @var $return MenuItems */
 		$return = $hook->getValue();
 
 		// cleanup all items
 		$items = [];
-		/* @var $menu_item \ElggMenuItem */
 		foreach ($allowed_items as $name) {
-			$items[] = $return->get($name);
+			/* @var $item \ElggMenuItem */
+			$item = $return->get($name);
+			$items[] = $item;
+
+			// some items could be in a submenu
+			$parent_name = $item->getParentName();
+			if (!empty($parent_name)) {
+				$items[] = $return->get($parent_name);
+			}
 		}
 
 		$return->fill($items);