Fix on key type

Coldwings · Jul 9, 2024 · a8b6878 · a8b6878
1 parent e8bf383
commit a8b6878
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/common/objectcachev2.h b/common/objectcachev2.h
@@ -110,14 +110,14 @@ class ObjectCacheV2 {
  }
 
  template <typename KeyType>
- Box* __find_or_create_item(const KeyType& key) {
+ Box* __find_or_create_item(KeyType&& key) {
  Box keyitem(key);
  auto pkey = &keyitem;
  Box* item = nullptr;
  SCOPED_LOCK(maplock);
  auto it = map.find(pkey);
  if (it == map.end()) {
- item = new Box(key);
+ item = new Box(std::forward<KeyType>(key));
  map.emplace(item);
  } else
  item = *it;
@@ -217,7 +217,7 @@ class ObjectCacheV2 {
 
  template <typename KeyType>
  Borrow borrow(KeyType&& key) {
- return borrow(&key, [&]() { return new V(); });
+ return borrow(std::forward<KeyType>(key), [&]() { return new V(); });
  }
 
  template <typename KeyType, typename Ctor>