handling erroneous dois

Coleridge-Initiative · Jul 13, 2020 · f42a807 · f42a807
1 parent 3417ca3
commit f42a807
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/richcontext/scholapi/scholapi.py b/richcontext/scholapi/scholapi.py
@@ -370,7 +370,10 @@ def publication_lookup (self, identifier):
 
         t0 = time.time()
         url = self._get_api_url(identifier)
-        meta = json.loads(requests.get(url).text)
+        response = requests.get(url)
+        if response.status_code == requests.codes.ok:
+            meta = json.loads(response.text)
+
         if not meta or len(meta) < 1 or "error" in meta:
             meta = None
         elif "message" in meta:

diff --git a/test.py b/test.py
@@ -364,6 +364,13 @@ def test_semantic_publication_lookup (self):
             response = source.publication_lookup(doi)
             self.assertTrue(response.meta == None)
 
+        # another error case
+        doi = "10.1641/0006-3568(2005)055[0879:EITLSA]2.0.CO;2"
+
+        if source.has_credentials():
+            response = source.publication_lookup(doi)
+            self.assertTrue(response.meta == None)
+
 
     ######################################################################
     ## Misc. family of APIs