feat: insert text and images generated with nextcloud assistant #10730
Conversation
|
I think this seems quite ready to review so, I have press the button "ready to review" . @elzody , if this is ready for review please rename the PR's title |
|
@elzody your branch looks not very up to date and thus I think it's missing some bits that is making CI not agreeable. Could you please rebase it? |
elzody
changed the title
elzody
force-pushed
the
feat/nc-ai-assistant
branch
from
820dfdb to
0e107c3
Compare
|
@pedropintosilva I went ahead and did a rebase onto master, it seems to have resolved some of the failing test, but some remain, and I am unsure how to interpret them to tell if they're related. |
|
I tried to run tests again, sometimes we have false failures |
|
Please rebase again, API was changed and it fails now |
elzody
force-pushed
the
feat/nc-ai-assistant
branch
from
0e107c3 to
998f012
Compare
elzody
force-pushed
the
feat/nc-ai-assistant
branch
from
998f012 to
cbb038b
Compare
This is needed as we are implementing a new feature in Nextcloud which integrates the Nextcloud AI Assistant. It will only be available if the required wopi attribute is passed in CheckFileInfo, which currently is only provided by Nextcloud. Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> Change-Id: Idfbc00f46b400413053b6068b327014b5ddd7a35
elzody
force-pushed
the
feat/nc-ai-assistant
branch
from
221ad9b to
a3d96a0
Compare
| @@ -91,6 +91,9 @@ class Dispatcher { | |||
| this.actionsMap['remotelink'] = function () { | |||
| app.map.fire('postMessage', { msgId: 'UI_PickLink' }); | |||
| }; | |||
| this.actionsMap['remoteaicontent'] = function () { | |||
| app.map.fire('postMessage', { msgId: 'UI_InsertAIContent' }); | |||
There was a problem hiding this comment.
so how does this work? What is the expected response to this message?
We'll need to update the documentation afterwards.
There was a problem hiding this comment.
We don't expect any response, the integrator can handle it with whatever they want. Our integration is inserting text for example: nextcloud/richdocuments#4333
@pedropintosilva The smart picker is also not documented.
Summary
These changes are needed from the Nextcloud side to support integrating the Nextcloud Assistant with Collabora. There is currently no way to add buttons to the notebook bar from other apps, so we would need to hardcode it just like we did with the Smart Picker.
The related pull request in richdocuments is: nextcloud/richdocuments#4333
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay