Skip to content

Commit

Permalink
Fix routing (#939)
Browse files Browse the repository at this point in the history
* reinstate working routing code and remove broken code

* forward object_info

* remove object_info bit
  • Loading branch information
mcmonkey4eva authored Sep 24, 2024
1 parent 9fb34cc commit fc4a689
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 19 deletions.
8 changes: 0 additions & 8 deletions .env_example
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,3 @@ EXAMPLE_REPO_PATH=tests-ui/ComfyUI_examples

# Whether to enable minification of the frontend code.
ENABLE_MINIFY=true

# ------ ViteJS related env variables ------
# Note: the VITE_ prefix is required

# Frontend base URL
# Note: default / is for http://localhost:5173/
# Example: /foobar/ will be served as http://localhost:5173/foobar/
VITE_BASE_URL=
3 changes: 1 addition & 2 deletions src/config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
export default {
app_title: 'ComfyUI',
app_version: __COMFYUI_FRONTEND_VERSION__,
base_url: import.meta.env.VITE_BASE_URL
app_version: __COMFYUI_FRONTEND_VERSION__
}
3 changes: 1 addition & 2 deletions src/router.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import config from '@/config'
import { createRouter, createWebHistory } from 'vue-router'
import LayoutDefault from '@/views/layouts/LayoutDefault.vue'

const router = createRouter({
history: createWebHistory(config.base_url),
history: createWebHistory(window.location.pathname),
routes: [
{
path: '/',
Expand Down
12 changes: 7 additions & 5 deletions src/scripts/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ interface QueuePromptRequestBody {
class ComfyApi extends EventTarget {
#registered = new Set()
api_host: string
api_base: string
initialClientId: string
user: string
socket?: WebSocket
Expand All @@ -42,21 +43,22 @@ class ComfyApi extends EventTarget {

constructor() {
super()
this.api_host = window.location.host
this.api_host = location.host
this.api_base = location.pathname.split('/').slice(0, -1).join('/')
console.log('Running on', this.api_host)
this.initialClientId = sessionStorage.getItem('clientId')
}

internalURL(route: string): string {
return '/internal' + route
return this.api_base + '/internal' + route
}

apiURL(route: string): string {
return '/api' + route
return this.api_base + '/api' + route
}

fileURL(route: string): string {
return route
return this.api_base + route
}

fetchApi(route: string, options?: RequestInit) {
Expand Down Expand Up @@ -112,7 +114,7 @@ class ComfyApi extends EventTarget {
existingSession = '?clientId=' + existingSession
}
this.socket = new WebSocket(
`ws${window.location.protocol === 'https:' ? 's' : ''}://${this.api_host}/ws${existingSession}`
`ws${window.location.protocol === 'https:' ? 's' : ''}://${this.api_host}${this.api_base}/ws${existingSession}`
)
this.socket.binaryType = 'arraybuffer'

Expand Down
8 changes: 6 additions & 2 deletions vite.config.mts
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,9 @@ function getModuleName(id: string): string {
}

const DEV_SERVER_COMFYUI_URL = process.env.DEV_SERVER_COMFYUI_URL || 'http://127.0.0.1:8188'
const VITE_BASE_URL = process.env.VITE_BASE_URL || '/'

export default defineConfig({
base: VITE_BASE_URL,
base: '',
server: {
proxy: {
'/internal': {
Expand All @@ -115,6 +114,11 @@ export default defineConfig({
'/ws': {
target: DEV_SERVER_COMFYUI_URL,
ws: true
},

'/testsubrouteindex': {
target: 'http://localhost:5173',
rewrite: (path) => path.substring('/testsubrouteindex'.length)
}
}
},
Expand Down

0 comments on commit fc4a689

Please sign in to comment.