Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Make the new Queue toolbar moveable in Comfy Front-End v1.3.0 #1001

Closed
1 task done
camoody1 opened this issue Sep 26, 2024 · 14 comments
Closed
1 task done
Assignees
Labels
enhancement New feature or request

Comments

@camoody1
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

I would like the new Queue toolbar to have a "grip/grab" textured section on the extreme right of the bar that the user can click on to drag the toolbar to different positions on the graph.

Proposed workflow

  1. Go to ....
  2. Press ....
  3. ...

Additional information

No response

@camoody1 camoody1 added the enhancement New feature or request label Sep 26, 2024
@JorgeR81
Copy link

JorgeR81 commented Sep 26, 2024

Ideally, the queue menu could be moveable and dockable, if dragged on to the Top Bar.

An option in the user settings to add it to the top bar would also do, but dockable menus would be pretty cool ...


EDIT:

OK, I just noticed the Top Bar has a different implementation from the Sidebar and the Floating menu ( e.g. different tool tooltips and slightly different button styles )

So docking would probably not look very good, unless the Top Bar implementation is updated.

@UrzasLegacy
Copy link
Contributor

Would love for it to be moveable, preferably dockable as there's a ton of unused real estate in the top bar currently.

@huchenlei huchenlei self-assigned this Sep 26, 2024
@huchenlei
Copy link
Member

Would love for it to be moveable, preferably dockable as there's a ton of unused real estate in the top bar currently.

BTW we do support displaying opened workflows as tabs on the topbar. #952
image

It's possible to manually edit (ComfyUI)/user/default/comfy.settings.json to have "Comfy.Workflow.WorkflowTabsPosition": "Topbar" to get access to this behavior.

Read more on #995

@JorgeR81
Copy link

JorgeR81 commented Sep 27, 2024

So the queue buttons were moved out of the Top Bar to make room for workflows tabs ?

Why not make this an user option ?
I like the workflows tabs, but I would prefer to have the queue buttons in the Top bar.

Alternatively, if we just use icons ( instead of text ) for all the Top Bar options, we probably have space for both.
And the workflow tabs ( with text ) would be easier to differentiate.  

@camoody1
Copy link
Author

Oh, please yes. Make the open workflows available as tabs in the top toolbar. I hate having to open the side bar to switch between workflows. And then having to click it again to close it. A Tab option in the User Settings would be outstanding.

@camoody1
Copy link
Author

camoody1 commented Sep 27, 2024

Would love for it to be moveable, preferably dockable as there's a ton of unused real estate in the top bar currently.

In an IDEAL world, this team could work with the author of Crystools to add his monitors to the top toolbar. I can't live without his monitors showing me my current CPU, RAM, VRAM and GPU Temp. Making this happen would be outstanding.

https://github.com/crystian/ComfyUI-Crystools

@huchenlei
Copy link
Member

Oh, please yes. Make the open workflows available as tabs in the top toolbar. I hate having to open the side bar to switch between workflows. And then having to click it again to close it. A Tab option in the User Settings would be outstanding.

It is explicitly hidden for browser users as @yoland68 think it would be bad/confusing for current users who has multiple browser level tabs open, and we currently lack a mechanism to sync the opened workflows across multiple browser tabs.

We are trying to listen for explicit metric / petition / feedback to send the message that this feature will make those users who previous use multiple browser level tabs no longer open multiple browser level tabs to make this the default behavior.

@camoody1
Copy link
Author

Oh, please yes. Make the open workflows available as tabs in the top toolbar. I hate having to open the side bar to switch between workflows. And then having to click it again to close it. A Tab option in the User Settings would be outstanding.

It is explicitly hidden for browser users as @yoland68 think it would be bad/confusing for current users who has multiple browser level tabs open, and we currently lack a mechanism to sync the opened workflows across multiple browser tabs.

We are trying to listen for explicit metric / petition / feedback to send the message that this feature will make those users who previous use multiple browser level tabs no longer open multiple browser level tabs to make this the default behavior.

I was once someone who used multiple browser windows to bounce back and forth between workflows. But once the new gui gave me an easy mechanism for opening multiple workflows, the old method of multiple windows became much more difficult. If you went a step further and actually added TABS for each workflow at the top of the Comfy window, it would FEEL like having multiple browser windows open without the extra difficulty of making sure everything was synced. This new method is much more user friendly and I, for one, am glad I switched.

@mijuku233
Copy link
Contributor

Oh, please yes. Make the open workflows available as tabs in the top toolbar. I hate having to open the side bar to switch between workflows. And then having to click it again to close it. A Tab option in the User Settings would be outstanding.

It is explicitly hidden for browser users as @yoland68 think it would be bad/confusing for current users who has multiple browser level tabs open, and we currently lack a mechanism to sync the opened workflows across multiple browser tabs.

We are trying to listen for explicit metric / petition / feedback to send the message that this feature will make those users who previous use multiple browser level tabs no longer open multiple browser level tabs to make this the default behavior.

I don't quite understand what you mean, why do you want to synchronize the workflows that are open?
People open multiple browser-level tabs just to edit/use different workflows, right?
I don't know if it's because of the synchronization of workflows, I can't create a copy of the same workflow, so the new workflow browser has no use value for me (I still use the most original method, export the workflow directly), I originally planned to raise an issue to explain this matter later.

@yoland68
Copy link
Member

So the queue buttons were moved out of the Top Bar to make room for workflows tabs ?

Why not make this an user option ? I like the workflows tabs, but I would prefer to have the queue buttons in the Top bar.

Alternatively, if we just use icons ( instead of text ) for all the Top Bar options, we probably have space for both. And the workflow tabs ( with text ) would be easier to differentiate.

Would love to hear more about your preference of keeping queue at the top? What's breaking or annoying to move the action-bar to the center of the screen? How did you handle this issue before the new beta UI is implemented in place?

@yoland68
Copy link
Member

So the queue buttons were moved out of the Top Bar to make room for workflows tabs ?
Why not make this an user option ? I like the workflows tabs, but I would prefer to have the queue buttons in the Top bar.
Alternatively, if we just use icons ( instead of text ) for all the Top Bar options, we probably have space for both. And the workflow tabs ( with text ) would be easier to differentiate.

Would love to hear more about your preference of keeping queue at the top? What's breaking or annoying to move the action-bar to the center of the screen? How did you handle this issue before the new beta UI is implemented in place?

Also, if you have a bit time, would love to see a screen recording of you interacting with the 1.3.1 release vs the previous top bar queue button. Feel free to DM me on Discord to share if you don't feel comfortable! 🙏🙏 Really appreciate your time! If you don't have time, it's all good!

@JorgeR81
Copy link

JorgeR81 commented Sep 27, 2024

So the queue buttons were moved out of the Top Bar to make room for workflows tabs ?

Why not make this an user option ? I like the workflows tabs, but I would prefer to have the queue buttons in the Top bar.

Alternatively, if we just use icons ( instead of text ) for all the Top Bar options, we probably have space for both. And the workflow tabs ( with text ) would be easier to differentiate.

Would love to hear more about your preference of keeping queue at the top? What's breaking or annoying to move the action-bar to the center of the screen? How did you handle this issue before the new beta UI is implemented in place?

The floating queue menu looks good and it could be nice as default, for new users that use simple workflows. 
I would agree that's probably the more convenient configuration to use with the Comfy UI default workflow.
But if you have larger workflows, you don't want floating panels in front of your nodes.

My suggestion is having user options for :

  • floating queue menu - or - integrated in the Topbar 
  • workflow tabs inside Comfy UI - or - using multiple browser tabs ( having both is unnecessary and can be confusing )

If necessary, I wouldn't mind having 2 rows in the topbar, but floating panels over a complex workflow is too distracting.   

@JorgeR81
Copy link

JorgeR81 commented Sep 28, 2024

BTW we do support displaying opened workflows as tabs on the topbar. #952

It's possible to manually edit (ComfyUI)/user/default/comfy.settings.json to have "Comfy.Workflow.WorkflowTabsPosition": "Topbar" to get access to this behavior.

Just tried this. It works great ! Didn't notice any issues.

You should make this the default, or at least make it an option in the GUI settings.


The draggable bar also works fine.
Aesthetically, it would look better, if the topbar had the same implementation / style.

bt

@JorgeR81
Copy link

JorgeR81 commented Sep 28, 2024

If it's not possible to make the floating panel dockable, could you consider making it a little smaller, to better fit on top of the Topbar.

bt2


With this positioning, I still can fit workflow 4 tabs ( which is more than enough most people ) in a single row, even with custom buttons, in a 1920 x 1080 display.

I could fit another tab if the Show Image Feed button had no text ( like before v1.3.0 )

bt3

bt3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants