Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Option to have toolbar transparency ( tying everything together ) #1030

Closed
1 task done
JorgeR81 opened this issue Sep 27, 2024 · 9 comments · Fixed by #1119
Closed
1 task done
Labels
enhancement New feature or request

Comments

@JorgeR81
Copy link

JorgeR81 commented Sep 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

This could be a good way to deal with the floating panel configuration.
I think the issue is not so much about the space we lose, but the fact that floating panels can be distracting, in a node interface.

In Blender most floating panels are really toolbars with full transparency, so you can only see the buttons.
And if you followed Blender development you may remember it started with full opacity, then some transparency and now full transparency, by default.

Proposed workflow

So you could have:

  • The current Sidebar, on the left side ( with full opacity )
  • An optional Topbar just for workflows tabs ( with full opacity ) ( Show opened workflows as topbar tabs #952 )
  • The current Topbar, below that ( with user selectable transparency )
  • A Bottombar, with the queue buttons ( with user selectable transparency )
    ( and maybe ... )
  • A Sidebar, on the right side, with the zoom buttons ( with user selectable transparency ) ( Graph canvas menu #1023 )

This will give plenty of space for new buttons or custom extensions, in the future.

We can have full transparency by default ( similar to Blender )
Some users may prefer the look of partial transparency ( like a glass panel ),
And users that don't like floating panels, just turn on full opacity. 

And, in the future, if some of these toolbars are moveable ( #1001 ), full transparency could be enabled automatically, if they are not docked ( not adjacent to the borders of the canvas ).

@JorgeR81 JorgeR81 added the enhancement New feature or request label Sep 27, 2024
@mijuku233
Copy link
Contributor

mijuku233 commented Sep 27, 2024

The main reason it's annoying is that floating panels obscure nodes.
You have to move the canvas/node to see and edit it.
It feels like "You must attack the minion with Taunt.", which is pretty annoying.
The suggestion you made doesn't solve the problem, it shrinks the canvas further, which makes it worse.

@mijuku233
Copy link
Contributor

I think the best solution is to make these floating panels optional settings.
People who like them can turn them on in the settings, and people who hate them can turn them off in the settings.

@yoland68
Copy link
Member

@mijuku233, oh man, you must dislike this feature here. We are traveling right now but will definitely revisit this feature here. Meanwhile if you have more specific recording of you using/explain the failures when floating panel s obstructing you, please post here (or DM me on Discord if you don't feel comfortable posting publicly) 🙏

Thank you for all the feedback!

@JorgeR81
Copy link
Author

I think the best solution is to make these floating panels optional settings.

Yeah, but if the floating panels are "disabled", the buttons need to go in a toolbar anyways.
 
Maybe we could have a hotkey just to hide all the toolbars / panels, when we need every inch of canvas space.

@JorgeR81
Copy link
Author

oh man, you must dislike this feature here.

I think the new feature looks good and may be the best option for many users.

But users ( especially Comfy UI users ) like to be able to customize things.

@yoland68
Copy link
Member

FYI, my discord is @yoland_y

@mijuku233
Copy link
Contributor

mijuku233 commented Sep 27, 2024

@yoland68
Without the floating menu options, I can directly see and edit the values ​​for the preprocessor and resolution.
屏幕截图 2024-09-27 231844
When the floating menu option is present, I cannot directly view or edit the values ​​of preprocessor and resolution.
屏幕截图 2024-09-27 233531

@mijuku233
Copy link
Contributor

mijuku233 commented Sep 27, 2024

@yoland68
The floating menu option is beautiful and it is friendly to ultra-wide screens.
But for some users, it will bring a bad experience.
Please allow future floating panels to be freely fixed to the top bar.
Finally, happy travels!

@dchatel
Copy link

dchatel commented Oct 1, 2024

An image says a lot...

If you're going to have long menu bars, why not use them in the first place?
image
What's worse with the graph resize menu at the bottom right corner is that:

  • the reset view button used to be at in the top bar. Then in the floating queue menu. And now there. Let's break users habits all the time. I'm sure they'll be happy.
  • the current resize menu is part of the div used for the graph itself. Meaning, you cannot easily move it outside of the graph area. I tried to move it in the top bar (where it belongs in my opinion), but the parents (graph-canvas-container, and another one) both have overflow: hidden property set. So if you move the resize menu outside of the graph it becomes invisible.

If the ultimate goal is to remove the menu bars completely, and instead introduce tons of floating elements in the graph, that's a regression. The top/side menu bars were introduced to remove the original large floating menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants