Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph canvas menu #1023

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Graph canvas menu #1023

merged 5 commits into from
Sep 30, 2024

Conversation

pythongosssss
Copy link
Member

@pythongosssss pythongosssss commented Sep 27, 2024

image
Add menu for canvas controls for zoom in/out/reset view/lock graph

Closes #593

Setting to hide/disable canvas menu:
image

@mijuku233
Copy link
Contributor

So there will be more and more floating panels? The comfyui front-end is developing in a bad direction. T_T
The canvas that should remain clean is being obscured by more and more floating panels, which is a nightmare

@JorgeR81
Copy link

Floating panels look good with small workflows, like the default one.
But it's not convenient for large workflows.

Please make all floating panels optional.
I wouldn't mind having a 2 row Topbar, with all buttons in there.

@qudix
Copy link

qudix commented Sep 27, 2024

I don't get this complaint, floating panels take less canvas real-estate compared to a bar that takes 100% horizontal and fixed vertical, even when it only contains a few buttons. I can see adding options to hide optional elements like these, but clearly interfaces like vscode and blender are the inspiration here.

@JorgeR81
Copy link

JorgeR81 commented Sep 27, 2024

I don't get this complaint, floating panels take less canvas real-estate compared to a bar that takes 100% horizontal and fixed vertical, even when it only contains a few buttons. I can see adding options to hide optional elements like these, but clearly interfaces like vscode and blender are the inspiration here.

I think the issue is not so much about the space we lose, but the fact that floating panels can be distracting, in a node interface.
But the Blender GUI could give some good inspiration on how to deal with this.
I've made a proposal based on that ( #1030 )

@huchenlei huchenlei marked this pull request as ready for review September 30, 2024 19:41
@huchenlei huchenlei merged commit f75f774 into main Sep 30, 2024
9 checks passed
@huchenlei huchenlei deleted the graph-canvas-menu branch September 30, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Tool button to lock the whole canvas
5 participants