Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] Add basic welcome screen #1491

Merged
merged 10 commits into from
Nov 10, 2024
Merged

[Electron] Add basic welcome screen #1491

merged 10 commits into from
Nov 10, 2024

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Nov 10, 2024

Add basic welcome screen for electron install.

image

Added 2 electron-only routes:

  • /server-start: A view that streams server logs when the comfyui server is booting up
  • /install A view for first time setup user to walk through install options

Execute npm run dev:electron to run electron dev server with electron API mocked.

Copy link

socket-security bot commented Nov 10, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@comfyorg/comfyui-electron-types@0.2.10 None 0 8.83 kB k1oride

🚮 Removed packages: npm/@comfyorg/comfyui-electron-types@0.2.9

View full report↗︎

@huchenlei huchenlei merged commit d9a3487 into main Nov 10, 2024
9 checks passed
@huchenlei huchenlei deleted the electron_startup branch November 10, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant