Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hotkeys triggering while editing properties panel values #606

Merged

Conversation

christian-byrne
Copy link
Collaborator

The keybind handler ignores events in TEXTAREA and INPUT, but the inputs in the litegraph properties panel are SPAN, causing shortcuts like q and r to activate while typing there.

Issue:

@huchenlei huchenlei changed the base branch from main to dev_temp August 23, 2024 20:29
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

@huchenlei huchenlei merged commit 1bd8d97 into Comfy-Org:dev_temp Aug 23, 2024
3 of 4 checks passed
huchenlei added a commit that referenced this pull request Aug 23, 2024
…607)

* Fix hotkeys triggering while editing properties panel values (#606)

* Add properties panel inputs to key handler ignore

* Add properties panel test

* Update test expectations [skip ci]

---------

Co-authored-by: bymyself <abolkonsky.rem@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
@christian-byrne christian-byrne deleted the properties-panel-event-bubble branch August 24, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants