Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom settings with callable options property #616

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

christian-byrne
Copy link
Collaborator

SettingsParams.options can be a function:

options?: Array<string | SettingOption> | ((value: any) => SettingOption[])

For combo settings, the options property is set here:

setting.options is not invoked automatically, and Primvue select.options expects any[], so the option fails to render.

Examples:

  • Crystools.whichHDD
  • pysssss.Workflows.Default Workflow

@huchenlei huchenlei merged commit f4242f8 into Comfy-Org:main Aug 24, 2024
4 checks passed
@christian-byrne christian-byrne deleted the custom-settings-options branch August 24, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants