Refactor node library drag and drop #617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the drag and drop listener was attached by mutation observer in
TreePlus
, which is invonvenient, as the mutation of the tree can happen in various format. For example, the bookmarked nodes were not made draggable by the mutation observer method before.After this refactor, the draggable functionality is attached with lifecycle hook of
NodeTreeLeaf
component, which is much more manageable.