Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix textarea undo history cleared by editAttention #635

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix textarea undo history cleared by editAttention #635

merged 1 commit into from
Aug 26, 2024

Conversation

webfiltered
Copy link
Collaborator

Expected:

  • Type word into multiline
  • ctrl + z -> text input is undone

Repro:

  • Type word into multiline
  • ctrl + up
  • ctrl + z
  • Nothing happens

@webfiltered webfiltered marked this pull request as ready for review August 26, 2024 11:39
huchenlei
huchenlei approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huchenlei huchenlei merged commit f9ae5aa into Comfy-Org:main Aug 26, 2024
4 checks passed
@huchenlei huchenlei mentioned this pull request Aug 26, 2024
Merged
@webfiltered webfiltered deleted the fix-multiline-undo branch August 27, 2024 10:18
@huchenlei huchenlei mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @huchenlei