Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark show missing models warning as experimental #670

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

huchenlei
Copy link
Member

Disable by default as the mechanism of saving workflow with model info is not there yet. Enable by default might create confusion to our users.

@huchenlei huchenlei merged commit fb5bb57 into main Aug 28, 2024
5 checks passed
@huchenlei huchenlei deleted the beta_setting branch August 28, 2024 20:22
@mcmonkey4eva
Copy link
Contributor

huh? This should be enabled by default - as you said, most workflows don't have it, so this doesn't affect most users regardless

@huchenlei
Copy link
Member Author

huh? This should be enabled by default - as you said, most workflows don't have it, so this doesn't affect most users regardless

I think the reason here is to prevent someone having around with this mechanism to all users before we release our official impl on saving model info in workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants