better badges for empty/loading model library folders #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
requested changes
Sep 24, 2024
|
null prop fallback makes the code a fair bit simpler and cures all prior review comments in one, nice |
huchenlei
reviewed
Sep 24, 2024
huchenlei
pushed a commit
that referenced
this pull request
Sep 24, 2024
* better badges for empty/loading model library folders for #945 * fix total count on loaded nodes * fix test break * additional test fix * use a null prop fallback instead of having to explicitly calc * patch
huchenlei
pushed a commit
that referenced
this pull request
Sep 25, 2024
* better badges for empty/loading model library folders for #945 * fix total count on loaded nodes * fix test break * additional test fix * use a null prop fallback instead of having to explicitly calc * patch
huchenlei
pushed a commit
that referenced
this pull request
Sep 25, 2024
* better badges for empty/loading model library folders for #945 * fix total count on loaded nodes * fix test break * additional test fix * use a null prop fallback instead of having to explicitly calc * patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #945
Unloaded folders display
?, empty folders display0Adds helper functions in the tree explorer code to support altering the badge text, similar to the icon alteration code.
Minor side change, but I also changed the
// ...comments documenting a few options to/** ... */doc comments so that IDEs will render them