Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't remove invalid dropdown values #998

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

mcmonkey4eva
Copy link
Member

for #963

The behavior of resetting dropdowns to the first entry like that is explicitly programmed in, so the most direct solution is just remove that behavior code.

Though there's open questions:

  • should this apply to all dropdowns, or should it be changed to a per-widget setting, so that eg model lists don't reset but something more static like a sampler would (ie, is it wanted that values silently reset? imo no this is rarely or never wanted behavior)
  • Should there be some form of better solution to this case, eg immediately highlight the node/widget as errored until the user adjusts it? (imo yes this would be very helpful)
  • Should whatever final solution we go with here, be synchronized to also happen on workflow first load? (imo yes. Currently if you merge this PR they will be in sync, as first workflow load doesn't reset values or do anything else, but if the error highlight is added, that should be applied to load as well)

@nathanshipley
Copy link

Not sure on all the questions, but for this:

Should there be some form of better solution to this case, eg immediately highlight the node/widget as errored until the user adjusts it? (imo yes this would be very helpful)

+1. Just would say, this would be super useful. I could quickly scan without having to press queue and see which nodes aren't going to work because they're missing a model/lora. Thanks!

@huchenlei huchenlei merged commit 0cf21b1 into main Sep 27, 2024
9 checks passed
@huchenlei huchenlei deleted the dont-remove-invalid-dropdown-values branch September 27, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants