fix 'unsaved' value when closing workflows #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
requested changes
Sep 26, 2024
|
I also noticed workflows are set as unsaved, when we drag a PNG or JSON file. Does this PR address this ? ( I was about to open an issue ) Most of the time, my "unsaved workflows" are just a PNG or JSON file I dragged in, to check the workflow. This way, I can have 10 unsaved workflows or more. |
|
Well that genuinely is an unsaved workflow -- quicker ways to clear out random workflows (eg shift+click close to bypass unsaved prompt) would be a valid feature request to file |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #735
Linked issue describes the problem well. I replicated it locally, tested, found it comes down to just this variable not getting unset where other variables are unset at, so I unset it there. After this update, reopening a saved workflow that you opened previously does correctly treat the workflow as initially being not unsaved.